refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead#577
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Jan 6, 2026
Merged
Conversation
…stead Ansible 2.20 has deprecated the use of Ansible facts as variables. For example, `ansible_distribution` is now deprecated in favor of `ansible_facts["distribution"]`. This is due to making the default setting `INJECT_FACTS_AS_VARS=false`. For now, this will create WARNING messages, but in Ansible 2.24 it will be an error. See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars Signed-off-by: Rich Megginson <[email protected]>
Reviewer's GuideRefactors the role and its tests to stop using deprecated top-level Ansible fact variables and instead consistently access facts via the ansible_facts dictionary so it works with INJECT_FACTS_AS_VARS=false, while also ensuring required facts (including pkg_mgr) are gathered. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
Author
|
[citest] |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `vars/main.yml:9` </location>
<code_context>
- distribution_major_version
- distribution_version
- os_family
+ - pkg_mgr
# the subsets of ansible_facts that need to be gathered in case any of the
</code_context>
<issue_to_address>
**issue:** Architecture fact is now used via ansible_facts but isn’t listed in required facts, which could lead to missing data when gathering a minimal fact subset.
`pkg_mgr` was correctly added to `__storage_required_facts` now that it’s accessed via `ansible_facts['pkg_mgr']`. Similarly, several distro var files now use `ansible_facts['architecture']`, but `architecture` is not in `__storage_required_facts`. If facts are gathered with a minimal subset, `architecture` may be missing at runtime, so it should likely be added here as well.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 16.54% 10.34% -6.21%
==========================================
Files 2 8 +6
Lines 284 2020 +1736
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1811 +1574
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vojtechtrefny
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example,
ansible_distributionis now deprecated in favor ofansible_facts["distribution"]. This is due to making the defaultsetting
INJECT_FACTS_AS_VARS=false. For now, this will create WARNINGmessages, but in Ansible 2.24 it will be an error.
See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars
Signed-off-by: Rich Megginson [email protected]
Summary by Sourcery
Update role variables, tasks, and tests to use the ansible_facts dictionary instead of legacy fact variables for compatibility with newer Ansible versions.
Enhancements:
Tests: